Attempt to upgrade to Babel 7 #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolness
commented
Feb 26, 2019
| /** | ||
| * This is an API for a mock window.fetch, which provides | ||
| * some convenience methods for network communications. | ||
| */ | ||
| interface MockFetch extends jest.MockInstance<FetchAPI> { | ||
| interface MockFetch extends jest.MockInstance<any, any> { |
There was a problem hiding this comment.
I don't really understand what's going on with the typing of jest.MockInstance but it's just for tests so I don't care too much. 🤷♂️
toolness
commented
Feb 26, 2019
package.json
Outdated
| "@types/webpack": "4.4.17", | ||
| "@types/webpack-bundle-analyzer": "2.13.0", | ||
| "@types/webpack-node-externals": "1.6.3", | ||
| "apollo": "2.1.8", | ||
| "apollo": "^2.5.1", |
There was a problem hiding this comment.
I had to upgrade this because I was running into apollographql/apollo-tooling#962.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like a new version of Babel was released in August 2018 and it is what all the latest versions of our tools are going to need, so we might as well upgrade it now.
What actually spurred this change was looking at lingui for #12; it requires that we use Babel to convert JSX syntax into JS, rather than relying on TypeScript to do that for us, and Babel 6's JSX transformer doesn't support the new React fragment syntax that we've been using. So this PR will allow me to experiment with integrating lingui into the project, but it's a good thing to do regardless.
To do