Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Babel to transform JSX instead of TypeScript #494

Merged
merged 10 commits into from
Mar 1, 2019

Conversation

toolness
Copy link
Collaborator

@toolness toolness commented Feb 28, 2019

This is another attempt to set up our build pipeline so we can try out lingui, or any of the other i10n libraries that use babel plugins to transform/collect strings in JSX. See #488 for rationale on why this needs to be done.

Instead of migrating away from ts-jest like the previous attempt (#492) tried to do, this PR attempts to fix ts-jest via kulshekhar/ts-jest#1004.

Notes

  • I tried disabling type checking in ts-jest to see if tests would run faster, but they didn't, which was surprising, since it vastly speeds up our webpack side of things. Odd.

  • This moves our build and test TypeScript compiler options to a new tsconfig.build.json file.

To do

  • Remove the --no-cache from the test:watch target.
  • See if we can actually set "jsx": "react" in tsconfig.json so that we get lint errors when we don't import React for anything with JSX in it, but change it to preserve in our actual build pipeline.

@toolness toolness changed the title Frontend garbage fire Use Babel to transform JSX instead of TypeScript Mar 1, 2019
@toolness toolness changed the title Use Babel to transform JSX instead of TypeScript Use Babel to transform JSX instead of TypeScript (ts-jest version) Mar 1, 2019
@toolness toolness changed the title Use Babel to transform JSX instead of TypeScript (ts-jest version) Use Babel to transform JSX instead of TypeScript Mar 1, 2019
@toolness toolness marked this pull request as ready for review March 1, 2019 23:35
@toolness toolness merged commit 87a12e7 into master Mar 1, 2019
@toolness toolness deleted the frontend-garbage-fire branch March 1, 2019 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant