You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babel-jest@24 will also use loadPartialConfig to be able to mix its own options into the config in an API-conforming manner. However, loadPartialConfig will throw an assertion error if the config has not only been loaded, but also had its plugins instantiatied. loadOptions() does the whole thing, including instantiating the plugins, so it can't be used for multiple config loading passes, only the final pass.
Note that this PR doesn't address #960 (comment) (unfortunately I don't understand enough about Babel to address that), it just fixes typings so the PR doesn't break the build.
Thanks @GeeWee! Since you merged this into master, should #960 be closed?
Also, how soon do you think you will publish a new release to npm? I originally tried setting my package.json's entry for ts-jest to https://github.com/kulshekhar/ts-jest#670503f65a79ec62712e5e4488b734c092b20a0f but that doesn't seem to work because it looks like this project has a build step that runs before publishing to npm...
Ack, ignore the part about re-publishing to npm--I realized ts-jest has a npm prepare script and that it wasn't executing on my CI system for a funky reason. Just fixed that and I'm able to use 670503f directly now!
Er yes, #960 is about more than the typings, but it contains broken typings... This PR was meant to fix #960's broken typings, and as such it builds upon #960 (note that this PR's first two commits are ebe8237 and 3c2b1cf, the same two commits that constitute #960)... 😣
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same thing as #960 but with the type errors fixed, maybe.
If it's desirable I could make this a PR against
jessidhia/patch-1instead of againstmaster.I am getting some really weird feedback when I run
npm testthough, so I am just starting this PR to see what Travis thinks of it.