Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a commondatabuilder tool #501

Merged
merged 17 commits into from
Mar 5, 2019
Merged

Add a commondatabuilder tool #501

merged 17 commits into from
Mar 5, 2019

Conversation

toolness
Copy link
Collaborator

@toolness toolness commented Mar 5, 2019 •
edited
Loading

This converts our Django choices from JSON to TypeScript, which aside from being useful for type checking (see also #142) will also be useful for internationalization (#12).

To do

  • Document this in the readme.
  • Add docs for the config structs.
  • Add a test ensuring the json and ts files are in-sync.
  • Remove unused functions.
  • Rename enumName to typeName.
  • Convert lease choices to use typescript types.
  • Convert signup intent to use typescript types.

@toolness toolness marked this pull request as ready for review March 5, 2019 19:13
@toolness toolness changed the title Add a commonbuilderdata tool Add a commondatabuilder tool Mar 5, 2019
@toolness toolness merged commit 0bf802f into master Mar 5, 2019
@toolness toolness deleted the commondatabuilder branch March 5, 2019 22:09
@toolness toolness mentioned this pull request Apr 23, 2020
Merged
toolness added a commit that referenced this pull request Apr 23, 2020
@toolness
Convert us-state-choices.json to TSX. (#1265)
812be3d 
This uses the commondatabuilder (introduced in #501) to convert our raw JSON state choices into a TypeScript file, which will allow us to do more dynamic things with them, such as using the module's exported `getUSStateChoiceLabels()` function to easily look up a state's full name from its two-letter abbreviation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@toolness