Various Filter QA changes to styles #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #11619: Reduce letter spacing of "Apply". |
|
This pull request has been linked to Shortcut Story #11633: Reduce padding of overflow pill under Landlord filter.. |
|
This pull request has been linked to Shortcut Story #11596: Increase letter spacing for filter headers slightly. |
kiwansim
reviewed
Apr 4, 2023
| @@ -368,6 +369,7 @@ | |||
| border: 1px solid $justfix-black; | |||
| padding: 0.8rem 0.6rem; | |||
| margin-bottom: 1.1rem; | |||
| letter-spacing: 0.02em; | |||
There was a problem hiding this comment.
what is the base font-size the em is referencing here?
There was a problem hiding this comment.
it's referring to the font size of the element, rather than the base. And it's 14px (1.4rem), which is set in the multi-select component.
|
This pull request has been linked to Shortcut Story #12186: multiselect searchbar text styles (mobile). |
kiwansim
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduce letter spacing for filter apply buttons
[sc-11619]
increase letter spacing for multiselect "+ X" more chip
[sc-11633]
fix spacing between multiselect selected chips
increase letter spacing for RS unit filter toggle
[sc-11596]
center multiselect input text and placeholder grey-600
[sc-12186]