Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Filter QA changes to styles #738

Merged
merged 5 commits into from
Apr 6, 2023
Merged

Various Filter QA changes to styles #738

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8cc98cd
reduce letter spacing for filter apply buttons
austensen Apr 3, 2023
6c44fb9
fix spacing between multiselect selected chips
austensen Apr 3, 2023
944f8d0
increase letter spacing for multiselect "+ X" more chip
austensen Apr 3, 2023
c8a60a2
increase letter spacing for RS unit filter toggle
austensen Apr 4, 2023
a86e92d
center multiselect input text and placeholder grey-600
austensen Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions client/src/styles/Multiselect.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@
.chip {
padding: 4px 10px;
background: #0096fb;
margin-right: 5px;
margin-bottom: 5px;
border-radius: 11px;
display: inline-flex;
align-items: center;
Expand Down
5 changes: 4 additions & 1 deletion client/src/styles/PortfolioFilters.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@
.filter-toggle {
gap: 1rem;
padding: 1rem;
letter-spacing: 0.02em;
.checkbox {
box-sizing: border-box;
border: 0.1rem solid $justfix-black;
Expand Down Expand Up @@ -341,7 +342,7 @@
.selectedListContainer {
display: flex;
flex-wrap: wrap;
gap: 0.4rem;
gap: 0.6rem;

.chip {
align-self: flex-start;
Expand All @@ -368,6 +369,7 @@
border: 1px solid $justfix-black;
padding: 0.8rem 0.6rem;
margin-bottom: 1.1rem;
letter-spacing: 0.02em;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the base font-size the em is referencing here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's referring to the font size of the element, rather than the base. And it's 14px (1.4rem), which is set in the multi-select component.

}
}
}
Expand All @@ -386,6 +388,7 @@
.button.is-primary {
align-self: center;
margin: 0.9rem 0 1rem 0;
letter-spacing: 0.02em;
}
@include for-phone-only() {
.minmax-container .button.is-primary {
Expand Down