add portfolio filter info alert on overview map #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will need to properly style scrollbars on windows later
|
This pull request has been linked to Shortcut Story #11997: Include tool tip pointing to Filters from Overview page. |
kiwansim
approved these changes
Apr 12, 2023
| addressPageRoutes: AddressPageRoutes; | ||
| }; | ||
|
|
||
| export const BigPortfolioAlert = ({ portfolioSize, className, ...props }: PortfolioAlertProps) => { |
There was a problem hiding this comment.
alerts would be an excellent candidate for making into a reusable class component in storybook later! esp since these exact patterns also exist in LOC rebrand
There was a problem hiding this comment.
Yeah for sure! That was the next one I was hoping to add, it should be mostly ready to copy over from here and just the styles need to be updated.
|
This pull request has been linked to Shortcut Story #12226: Implement new tooltip on overview map styling.. |
austensen
added a commit
that referenced
this pull request
Apr 28, 2023
This reverts commit 2cc5013.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new info alert on the Overview page map prompting users to use the portfolio filters when the portfolio has >= 15 properties. This also restyles the "big portfolio" warning alert to look the same. Both alerts stay closed for the session.
[sc-11997]