Filter toast alerts #745
Merged
Filter toast alerts #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will need to properly style scrollbars on windows later
|
This pull request has been linked to Shortcut Story #11895: Toast placement with screen reader in mind etc.. |
kiwansim
approved these changes
Apr 12, 2023
|
[sc-12229] |
austensen
added a commit
that referenced
this pull request
Apr 28, 2023
This reverts commit 0ea245c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the placement of the alerts that appear once particular filters are applied. This were first added in #720 as "toast" notifications, that pop up for a few seconds at the bottom of the screen. Design decided to change the placement of these to show up in the place of the first table row. For accessibility the alerts still have
role="status"so they are read out ("polite") once they appear so you get the info read out right after the number of results without having to navigate around in the table. And when one of the alerts is closed it won't reappear for the session. Multiple alerts stack. The copy for each of these is also updated for the final content decisions.[sc-11895]