Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macosArm64 target #123

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Add macosArm64 target #123

merged 1 commit into from
Jun 8, 2022

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Jun 7, 2022

No description provided.

@twyatt twyatt requested review from a team, QuantumRand and cedrickcooke June 7, 2022 19:49
@twyatt twyatt added this to the 0.8.0 milestone Jun 7, 2022
@twyatt twyatt enabled auto-merge (squash) June 7, 2022 19:50
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #123 (8e9f148) into main (56a59f1) will increase coverage by 0.36%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##               main     #123      +/-   ##
============================================
+ Coverage     57.25%   57.62%   +0.36%     
  Complexity       11       11              
============================================
  Files             8        8              
  Lines           613      656      +43     
  Branches        145      145              
============================================
+ Hits            351      378      +27     
- Misses          223      239      +16     
  Partials         39       39              
Impacted Files Coverage Δ
koap/src/commonMain/kotlin/Message.kt 57.44% <33.33%> (-1.79%) ⬇️
koap/src/commonMain/kotlin/Debug.kt 26.08% <0.00%> (-1.19%) ⬇️
koap/src/commonMain/kotlin/ByteArrayReader.kt 68.08% <0.00%> (-0.10%) ⬇️
koap/src/commonMain/kotlin/Decoder.kt 53.74% <0.00%> (+1.62%) ⬆️
koap/src/commonMain/kotlin/Encoder.kt 71.69% <0.00%> (+3.27%) ⬆️
koap/src/commonMain/kotlin/Option.kt 26.31% <0.00%> (+4.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37a42a5...8e9f148. Read the comment docs.

@@ -17,6 +17,7 @@ kotlin {
jvm()
js().browser()
macosX64()
macosArm64()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, hard to believe it can be this simple when there's no platform specific source sets

@twyatt twyatt merged commit 11efa8f into main Jun 8, 2022
@twyatt twyatt deleted the twyatt/macosArm64 branch June 8, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants