Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove metadata workaround #170

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Remove metadata workaround #170

merged 1 commit into from
Feb 23, 2023

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Feb 22, 2023

This seems to have been resolved after upgrading a number of dependencies:

Dependency Version
Kotlin 1.8.10
Gradle 8
AtomicFU 0.19.0
binary-compatibility-validator 0.13.0

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #170 (df5105f) into main (56a59f1) will increase coverage by 0.71%.
The diff coverage is 45.45%.

@@             Coverage Diff              @@
##               main     #170      +/-   ##
============================================
+ Coverage     57.25%   57.97%   +0.71%     
  Complexity       11       11              
============================================
  Files             8        8              
  Lines           613      652      +39     
  Branches        145      144       -1     
============================================
+ Hits            351      378      +27     
- Misses          223      235      +12     
  Partials         39       39              
Impacted Files Coverage Δ
koap/src/commonMain/kotlin/Encoder.kt 71.69% <ø> (+3.27%) ⬆️
koap/src/commonMain/kotlin/ToFormat.kt 26.31% <ø> (ø)
koap/src/commonMain/kotlin/Debug.kt 26.08% <25.00%> (-1.19%) ⬇️
koap/src/commonMain/kotlin/Message.kt 57.85% <33.33%> (-1.38%) ⬇️
koap/src/commonMain/kotlin/ByteArrayReader.kt 68.08% <66.66%> (-0.10%) ⬇️
koap/src/commonMain/kotlin/Decoder.kt 53.74% <66.66%> (+1.62%) ⬆️
koap/src/commonMain/kotlin/Header.kt 53.84% <100.00%> (+3.84%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@twyatt twyatt added the maintenance General maintenance that doesn't effect the public API. label Feb 22, 2023
@twyatt twyatt marked this pull request as ready for review February 22, 2023 20:03
@twyatt twyatt requested a review from a team as a code owner February 22, 2023 20:03
@twyatt twyatt enabled auto-merge (squash) February 22, 2023 20:06
@twyatt twyatt merged commit 3487cd2 into main Feb 23, 2023
@twyatt twyatt deleted the twyatt/metadata branch February 23, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General maintenance that doesn't effect the public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants