Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support implementing a custom constructor from Rust #550

Closed
LeonMatthesKDAB opened this issue May 26, 2023 · 1 comment · Fixed by #566 or #639
Closed

Support implementing a custom constructor from Rust #550

LeonMatthesKDAB opened this issue May 26, 2023 · 1 comment · Fixed by #566 or #639
Assignees
@LeonMatthesKDAB @ahayzen-kdab
Labels
⬆️ feature New feature or request 🥳🎉 1.0 This issue is part of stabilization for 1.0 release
Milestone
0.6

Comments

@LeonMatthesKDAB
Copy link
Collaborator

LeonMatthesKDAB commented May 26, 2023 •
edited
Loading

See the answer in #339 for intended API.

This would solve:

  • Providing non-default constructor
  • Relaxing requirement for Default on a qobject type.
  • Allow calling non-default base class constructors in C++ (e.g. when deriving from QQuickItem)

Depends on #562
@LeonMatthesKDAB LeonMatthesKDAB added the ⬆️ feature New feature or request label May 26, 2023
@LeonMatthesKDAB LeonMatthesKDAB added this to the 0.6 milestone May 26, 2023
@LeonMatthesKDAB LeonMatthesKDAB mentioned this issue May 26, 2023
Closed
LeonMatthesKDAB added a commit to LeonMatthesKDAB/cxx-qt that referenced this issue May 26, 2023
@LeonMatthesKDAB
cxx-qt: Add a QtObject trait
e81283c 
This trait is automatically implemented on any `qobject::T`.
It currently exposes the inner Rust type for a given QObject.

First step of implementing KDAB#550

This also requires us to split our macros into a cxx-qt-macro crate, as
otherwise only exporting proc-macros is allowed.
We could now potentially move CxxQtThread into the cxx-qt crate now to
remove the dependency on cxx-qt-lib.
@LeonMatthesKDAB LeonMatthesKDAB mentioned this issue May 26, 2023
Merged
@LeonMatthesKDAB LeonMatthesKDAB added the 🥳🎉 1.0 This issue is part of stabilization for 1.0 release label May 29, 2023
@LeonMatthesKDAB LeonMatthesKDAB mentioned this issue May 30, 2023
Merged
@LeonMatthesKDAB
Copy link
Collaborator Author

Accidentally closed this in #566, even though that didn't fully test & document the feature yet

@LeonMatthesKDAB LeonMatthesKDAB mentioned this issue Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeonMatthesKDAB LeonMatthesKDAB

@ahayzen-kdab ahayzen-kdab

Labels
⬆️ feature New feature or request 🥳🎉 1.0 This issue is part of stabilization for 1.0 release
Projects
None yet
Milestone
0.6
Development

Successfully merging a pull request may close this issue.

Constructor trait LeonMatthesKDAB/cxx-qt
Constructor documentation LeonMatthesKDAB/cxx-qt
2 participants
@LeonMatthesKDAB @ahayzen-kdab