Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constructor documentation #639

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Constructor documentation #639

merged 2 commits into from
Aug 9, 2023

Conversation

LeonMatthesKDAB
Copy link
Collaborator

Closes #550

Be-ing
Be-ing suggested changes Jul 31, 2023
View reviewed changes
@LeonMatthesKDAB LeonMatthesKDAB force-pushed the constructor-documentation branch 4 times, most recently from 58874ba to 5b0feb1 Compare August 4, 2023 12:09
@LeonMatthesKDAB LeonMatthesKDAB marked this pull request as ready for review August 4, 2023 12:14
@LeonMatthesKDAB LeonMatthesKDAB force-pushed the constructor-documentation branch 2 times, most recently from 97fd8b9 to a5b5aa2 Compare August 4, 2023 14:15
ahayzen-kdab
ahayzen-kdab previously approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@ahayzen-kdab ahayzen-kdab force-pushed the constructor-documentation branch from a5b5aa2 to 398eaeb Compare August 7, 2023 17:31
Be-ing
Be-ing previously requested changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@Be-ing Be-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor things

@LeonMatthesKDAB
Add cxx_qt::Initialize trait.
09e26b5 
Useful for avoiding Constructor boilerplate when all you want is to
initialize the QObject after construction.
@LeonMatthesKDAB
Document cxx_qt::Constructor trait.
868859f 
The Constructor is now stable enough to become public API.
@LeonMatthesKDAB LeonMatthesKDAB force-pushed the constructor-documentation branch from 398eaeb to 868859f Compare August 9, 2023 09:08
ahayzen-kdab
ahayzen-kdab approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@ahayzen-kdab ahayzen-kdab dismissed Be-ing’s stale review August 9, 2023 09:29

comments have been solved

@ahayzen-kdab ahayzen-kdab enabled auto-merge (rebase) August 9, 2023 09:29
@ahayzen-kdab ahayzen-kdab merged commit 304e1f9 into KDAB:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahayzen-kdab ahayzen-kdab ahayzen-kdab approved these changes

@Be-ing Be-ing Be-ing left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support implementing a custom constructor from Rust
3 participants
@LeonMatthesKDAB @Be-ing @ahayzen-kdab