cxx-qt-gen: change rust_mut to be safe and remove field generation #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we move qproperty to an attribute we need to disable generating helpers for fields as we won't be able to find them when the struct is outside the bridge. There are three options going forwards - let the developer create their own getters/setters (this commit) - add a #[field(T, NAME)] as an attribute to the qobject later - remove the (un)safe for qproperty with notify so that rust_mut is safe Related to KDAB#559
ahayzen-kdab
commented
Jun 13, 2023
ahayzen-kdab
force-pushed
the
559-allow-field-access-safely
branch
from
d018985 to
10c80e1
Compare
As rust_mut is now safe. Related to KDAB#559
ahayzen-kdab
added
the
🥳🎉 1.0
ahayzen-kdab
commented
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #559
Related to #583