Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cxx-qt-gen: impl Deref for qobject::T to reach T easily #586

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

ahayzen-kdab
Copy link
Collaborator

Related to #559

Requires #585

@ahayzen-kdab ahayzen-kdab force-pushed the 559-deref-helper branch 2 times, most recently from b8c2ed9 to 1e131b2 Compare June 21, 2023 15:13
@ahayzen-kdab ahayzen-kdab marked this pull request as ready for review June 21, 2023 15:13
@ahayzen-kdab ahayzen-kdab added the 🥳🎉 1.0 This issue is part of stabilization for 1.0 release label Jun 22, 2023
LeonMatthesKDAB
LeonMatthesKDAB previously approved these changes Jul 7, 2023
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a very welcome change, there are probably a few more as_ref calls that we may have missed, but that's not a big deal.

Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great ergonomic change

@ahayzen-kdab ahayzen-kdab enabled auto-merge (rebase) July 19, 2023 09:17
@ahayzen-kdab ahayzen-kdab merged commit a9c1b4e into KDAB:main Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥳🎉 1.0 This issue is part of stabilization for 1.0 release
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants