New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some more api to jsondocument #76

Merged

mgiroday merged 1 commit into KDAB:main from mgiroday:add-some-more-api-to-jsondocument

Aug 23, 2024

Contributor

mgiroday commented Jun 28, 2024 •

edited by narnaud

Loading

No description provided.

narnaud reviewed

View reviewed changes

src/core/settings.h Outdated Show resolved Hide resolved

narnaud reviewed

View reviewed changes

src/core/jsonutilities.h Outdated Show resolved Hide resolved

narnaud reviewed

View reviewed changes

src/core/jsonutilities.h Outdated Show resolved Hide resolved

narnaud reviewed

View reviewed changes

src/core/jsonutilities.h Outdated Show resolved Hide resolved

narnaud reviewed

View reviewed changes

src/core/jsonutilities.h Outdated Show resolved Hide resolved

narnaud reviewed

View reviewed changes

src/core/jsonutilities.h Outdated Show resolved Hide resolved

narnaud reviewed

View reviewed changes

src/core/jsonutilities.cpp Outdated Show resolved Hide resolved

narnaud reviewed

View reviewed changes

src/core/jsonutilities.cpp Outdated Show resolved Hide resolved

narnaud reviewed

View reviewed changes

src/core/jsonutilities.cpp Outdated Show resolved Hide resolved

narnaud reviewed

View reviewed changes

src/core/jsonutilities.cpp Outdated Show resolved Hide resolved

narnaud reviewed

View reviewed changes

src/core/jsonutilities.cpp Outdated Show resolved Hide resolved

narnaud reviewed

View reviewed changes

src/core/jsonutilities.cpp Outdated Show resolved Hide resolved

narnaud reviewed

View reviewed changes

src/core/jsonutilities.cpp Outdated Show resolved Hide resolved

narnaud reviewed

View reviewed changes

src/core/jsondocument.cpp Show resolved Hide resolved

narnaud reviewed

View reviewed changes

src/core/jsondocument.cpp Outdated Show resolved Hide resolved

narnaud reviewed

View reviewed changes

src/core/settings.cpp Show resolved Hide resolved

narnaud reviewed

View reviewed changes

tests/tst_jsondocument.cpp Outdated Show resolved Hide resolved

narnaud reviewed

View reviewed changes

Member

narnaud left a comment

This is the general direction of the patch, thank you.

mgiroday force-pushed the add-some-more-api-to-jsondocument branch 2 times, most recently from 7e5b9dd to 670c2c2 Compare

August 13, 2024 10:40

narnaud reviewed

View reviewed changes

Member

narnaud left a comment

Way better, small nitpicking and good to go.

src/core/jsondocument.h Outdated Show resolved Hide resolved

src/core/jsondocument.cpp Outdated Show resolved Hide resolved

src/core/settings.cpp Outdated Show resolved Hide resolved

src/core/settings.cpp Outdated Show resolved Hide resolved

src/core/settings.h Outdated Show resolved Hide resolved

tests/tst_jsondocument.cpp Outdated Show resolved Hide resolved

mgiroday force-pushed the add-some-more-api-to-jsondocument branch from 670c2c2 to 9f89915 Compare

August 21, 2024 10:41

narnaud approved these changes

View reviewed changes


          feat: Add some more API to JsonDocument

463ab4a

Issue KDAB#31

mgiroday force-pushed the add-some-more-api-to-jsondocument branch from 9f89915 to 463ab4a Compare

August 23, 2024 04:54

mgiroday merged commit 2559458 into KDAB:main

5 checks passed

mgiroday deleted the add-some-more-api-to-jsondocument branch

August 23, 2024 05:04

LeonMatthesKDAB mentioned this pull request

chore(main): release 1.0.0 #86

Open

mgiroday mentioned this pull request

improve search in document #160

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet