feat: add a method to change the context of a message #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smnppKDAB
force-pushed
the
sperret-setContext
branch
from
58c23f9 to
476d956
Compare
dfaure-kdab
reviewed
Jul 22, 2024
|
Using the IDS_FOO which is stored in the "comment" to look up a specific message was my idea, but looking back at the merge request now I have to wonder if that's the right way to do this. When knut is used in another context than a MFC migration, the comment might not be a unique identifier for the message.... I think we need to pass context+comment+source (the message to be translated), to better identify the message that we want to move (same "key" as what tr() uses, AFAIK). |
smnppKDAB
force-pushed
the
sperret-setContext
branch
from
93bdc1d to
c96398c
Compare
dfaure-kdab
requested changes
Jul 23, 2024
smnppKDAB
force-pushed
the
sperret-setContext
branch
from
4d8d488 to
2c68a78
Compare
dfaure-kdab
reviewed
Jul 23, 2024
smnppKDAB
force-pushed
the
sperret-setContext
branch
from
34c0d3b to
91d1359
Compare
smnppKDAB
force-pushed
the
sperret-setContext
branch
from
c61875a to
b54b72a
Compare
for more information, see https://pre-commit.ci
dfaure-kdab
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.