Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change syntax of comments to remove warning #139

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

smnppKDAB
Copy link
Collaborator

warning concerned:
726:40: warning: '/*' within block comment [-Wcomment]

  • {} to group conditions (e.g. **<U+200B>/*.{ts,js} matches all TypeScript and JavaScript files)

@smnppKDAB smnppKDAB requested a review from dfaure-kdab August 2, 2024 15:48
@dfaure-kdab
Copy link
Member

The question is, is the documentation still picked up by the documentation-generation-tool?

@smnppKDAB
Copy link
Collaborator Author

smnppKDAB commented Aug 5, 2024

The question is, is the documentation still picked up by the documentation-generation-tool?

@dfaure-kdab
I just made a diff on the docs directories and this commit makes no changes to the documentation

warning concerned:
726:40: warning: '/*' within block comment [-Wcomment]
- `{}` to group conditions (e.g. `**<U+200B>/*.{ts,js}` matches all TypeScript and JavaScript files)
@smnppKDAB smnppKDAB force-pushed the sperret-commentWarning branch from ea8fad8 to de215fb Compare August 5, 2024 08:45
@dfaure-kdab dfaure-kdab merged commit 62ed9fc into KDAB:main Aug 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants