feat: add a find in files API to Project
#143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfaure-kdab
requested changes
Aug 7, 2024
smnppKDAB
force-pushed
the
sperret-findInFile
branch
from
2aa57db to
911d9d9
Compare
smnppKDAB
force-pushed
the
sperret-findInFile
branch
3 times, most recently
from
66fecd4 to
5f37628
Compare
dfaure-kdab
reviewed
Aug 7, 2024
dfaure-kdab
requested changes
Aug 7, 2024
smnppKDAB
force-pushed
the
sperret-findInFile
branch
from
5f37628 to
0800c1c
Compare
dfaure-kdab
reviewed
Aug 8, 2024
smnppKDAB
force-pushed
the
sperret-findInFile
branch
from
0800c1c to
39569de
Compare
smnppKDAB
force-pushed
the
sperret-findInFile
branch
from
39569de to
cb1d611
Compare
dfaure-kdab
reviewed
Aug 8, 2024
smnppKDAB
force-pushed
the
sperret-findInFile
branch
from
cb1d611 to
7b1d813
Compare
dfaure-kdab
previously approved these changes
Aug 9, 2024
smnppKDAB
force-pushed
the
sperret-findInFile
branch
2 times, most recently
from
10ea426 to
e36bbd9
Compare
narnaud
reviewed
Aug 14, 2024
smnppKDAB
force-pushed
the
sperret-findInFile
branch
2 times, most recently
from
85b19f8 to
014aac7
Compare
narnaud
previously approved these changes
Aug 20, 2024
dfaure-kdab
requested changes
Aug 21, 2024
The API return a list of document + position of the find items. The method uses ripgrep (rg) for searching, which must be installed and accessible in PATH. The `pattern` parameter should be a valid regular expression. Fixes KDAB#21
smnppKDAB
force-pushed
the
sperret-findInFile
branch
from
014aac7 to
182baea
Compare
dfaure-kdab
approved these changes
Aug 21, 2024
narnaud
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methode return a list of document + position of the find items.
The method uses ripgrep (rg) for searching, which must be installed and accessible in PATH.
The
patternparameter should be a valid regular expression.Fixes #21