fix: move return in the changeValue method to ensure proper execution flow #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smnppKDAB
force-pushed
the
sperret-returnRightPosition
branch
2 times, most recently
from
d604d73 to
64d84a0
Compare
smnppKDAB
changed the title
… flow move the returns inside the `if` condition to be sure that if a condition is not verified then we reach the case where the widget is not supported
smnppKDAB
force-pushed
the
sperret-returnRightPosition
branch
from
64d84a0 to
2e965f2
Compare
dfaure-kdab
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move the returns to be sure that if a condition is not verified then we reach the case where the widget is not supported