Merge #2426 Ignore splitter exceptions

KSP-CKAN · Apr 25, 2018 · 29c8025 · 29c8025
2 parents 17e2ae6 + 1ca841b
commit 29c8025
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,12 +5,13 @@ All notable changes to this project will be documented in this file.
 ## v1.25.1
 
 ### Features
-- [GUI] Replace empty max KSP version string with "any" #2420
+- [GUI] Replace empty max KSP version string with "any" (#2420 by: DasSkellet; reviewed: HebaruSan, politas)
 
 ### Bugfixes
 - [GUI] Splitter and tabstrip visual improvements (#2413 by: HebaruSan; reviewed: politas)
 - [GUI] Fix "Collection was modified" exception for redundant optional dependencies (#2423 by: HebaruSan; reviewed: politas)
 - [core] Treat installed DLC as compatible dependency (#2424 by: HebaruSan; reviewed: politas)
+- [GUI] Ignore splitter exceptions (#2426 by: HebaruSan; reviewed: politas)
 
 ### Internal
 

diff --git a/GUI/Main.cs b/GUI/Main.cs
@@ -280,7 +280,15 @@ protected override void OnLoad(EventArgs e)
             Location = configuration.WindowLoc;
             Size = configuration.WindowSize;
             WindowState = configuration.IsWindowMaximised ? FormWindowState.Maximized : FormWindowState.Normal;
-            splitContainer1.SplitterDistance = configuration.PanelPosition;
+            try
+            {
+                splitContainer1.SplitterDistance = configuration.PanelPosition;
+            }
+            catch
+            {
+                // SplitContainer is mis-designed to throw exceptions
+                // if the min/max limits are exceeded rather than simply obeying them.
+            }
             ModInfoTabControl.ModMetaSplitPosition = configuration.ModInfoPosition;
 
             if (!configuration.CheckForUpdatesOnLaunchNoNag && AutoUpdate.CanUpdate)

diff --git a/GUI/MainModInfo.Designer.cs b/GUI/MainModInfo.Designer.cs
diff --git a/GUI/MainModInfo.cs b/GUI/MainModInfo.cs
@@ -69,7 +69,15 @@ public int ModMetaSplitPosition
             }
             set
             {
-                this.splitContainer2.SplitterDistance = value;
+                try
+                {
+                    this.splitContainer2.SplitterDistance = value;
+                }
+                catch
+                {
+                    // SplitContainer is mis-designed to throw exceptions
+                    // if the min/max limits are exceeded rather than simply obeying them.
+                }
             }
         }