Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore splitter exceptions #2426

Merged
merged 1 commit into from
Apr 25, 2018
Merged

Conversation

HebaruSan
Copy link
Member

Problem

In #2413, I set the Panel1MinSize and Panel2MinSize properties on our splitters, because they look like a simple way to ensure that important content is visible. Of course with .NET, even something this simple has to be arduous:

image

This happens at start-up if our saved splitter size is no longer allowed in the current window size. You can get to such a state easily by resizing the window with no problems, but then if you close and restart this exception is thrown.

Changes

We may not be able to convince Microsoft how dumb it is to throw this exception, but now we do the next best thing and ignore it. The min sizes of the mod info pane are also reduced to about 75% of their previous values to allow them to fit a bit better into small windows.

@HebaruSan HebaruSan added Bug GUI Issues affecting the interactive GUI Pull request and removed Bug labels Apr 25, 2018
@HebaruSan
Copy link
Member Author

@politas, we should not ship a 1.25.1 without this fix (or a better solution to the same problem). This exception locks the user out of the application, so the only way to work around it is to edit the config file where the saved splitter position is stored.

@HebaruSan HebaruSan added the Bug label Apr 25, 2018
@politas politas merged commit 1ca841b into KSP-CKAN:master Apr 25, 2018
politas added a commit that referenced this pull request Apr 25, 2018
@HebaruSan HebaruSan deleted the fix/splitter-exception branch April 25, 2018 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants