-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitter and tabstrip visual improvements #2413
Conversation
Can you push all labels in the lower part of metadata tab some pixels down? |
7f826b3
to
152e6de
Compare
@DasSkelett, I think so, see new screenshot and amended commit. |
Wow, looks great now! |
Have you fixed it so the main splitter still works when tabs other than the mod details is shown? (An issue I noticed the other day but haven't had a chance to look at in detail, yet) |
I haven't consciously made any changes along those lines, but testing it out I don't see a problem with it either. I might not be understanding the issue though. |
@politas, that was to fix that control being gray on white on Windows, which happened because it's a |
Cool. The .Net/Mono promise of multi-platform UI development is not quite fulfilled, eh? |
Problem
GUI has a vertical splitter between the mod list and the mod info pane and a horizontal splitter within one of the tabs of the mod info pane, but some users have found this to be non-obvious and ask whether information has been removed from the display (see #2412 and KSP-CKAN/NetKAN#6288).
The tab style chosen for the mod info pane is also a bit ugly and gray.
Changes
Now each pane of these splitters has a minimum size:
(I tried to enlarge the horizontal splitter as well, but setting the property had no effect.)
And the tabs are changed to a more conventional style, which also gives the tab pages a white background.
Minimum sizes of the panes illustrated: