Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitter and tabstrip visual improvements #2413

Merged
merged 2 commits into from
Apr 22, 2018

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Apr 18, 2018

Problem

GUI has a vertical splitter between the mod list and the mod info pane and a horizontal splitter within one of the tabs of the mod info pane, but some users have found this to be non-obvious and ask whether information has been removed from the display (see #2412 and KSP-CKAN/NetKAN#6288).

The tab style chosen for the mod info pane is also a bit ugly and gray.

screenshot

splitter low splitter high

Changes

Now each pane of these splitters has a minimum size:

  • The mod info pane always has enough width for all of its tabs
  • The top part of the metadata tab always has enough height for both of its fields
  • The bottom part of the metadata tab always has enough height for its fields
  • The vertical splitter itself is widened slightly to try to make it more obvious
    (I tried to enlarge the horizontal splitter as well, but setting the property had no effect.)

And the tabs are changed to a more conventional style, which also gives the tab pages a white background.

Minimum sizes of the panes illustrated:

image

@HebaruSan HebaruSan added the GUI Issues affecting the interactive GUI label Apr 18, 2018
@DasSkelett
Copy link
Member

DasSkelett commented Apr 18, 2018

Can you push all labels in the lower part of metadata tab some pixels down?
I think the Version text is sticking a bit too close to the splitter.

@HebaruSan
Copy link
Member Author

@DasSkelett, I think so, see new screenshot and amended commit.

@DasSkelett
Copy link
Member

Wow, looks great now!

@politas
Copy link
Member

politas commented Apr 19, 2018

Have you fixed it so the main splitter still works when tabs other than the mod details is shown? (An issue I noticed the other day but haven't had a chance to look at in detail, yet)

@HebaruSan
Copy link
Member Author

I haven't consciously made any changes along those lines, but testing it out I don't see a problem with it either. I might not be understanding the issue though.

@politas
Copy link
Member

politas commented Apr 20, 2018

Seems to work fine in this branch, so all good. I do note that the abstract is using the "Input Box" background colour, while the rest of the metadata is using the "Windows" background. Can we get them using the same style?
image

@HebaruSan
Copy link
Member Author

@politas, that was to fix that control being gray on white on Windows, which happened because it's a RichTextBox with ReadOnly set to true, and .NET and Mono apparently don't use the same colors for tabs. I've changed it to a Label and removed the color manipulation, so it should match the main background on both platforms now.

@politas
Copy link
Member

politas commented Apr 20, 2018

Cool. The .Net/Mono promise of multi-platform UI development is not quite fulfilled, eh?

@politas politas merged commit 5fe734c into KSP-CKAN:master Apr 22, 2018
@HebaruSan HebaruSan deleted the fix/splitter-sizes branch April 22, 2018 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants