Merge #2663 Get license from GitHub

CHANGELOG.md

@@ -15,6 +15,7 @@ All notable changes to this project will be documented in this file.
 - [Multiple] Show progress bar while loading registry (#2617 by: HebaruSan; reviewed: politas)
 - [Multiple] Add possibility to clone KSP installs and create dummy ones (#2627 by: DasSkelett; reviewed: HebaruSan, politas)
 - [ConsoleUI] Allow overriding menu tip in ConsoleUI (#2635 by: HebaruSan; reviewed: DasSkelett, politas)
+- [Netkan] Get license from GitHub (#2663 by: HebaruSan; reviewed: politas)
 
 ### Bugfixes
 

Netkan/Sources/Github/GithubRepo.cs

@@ -18,5 +18,14 @@ public sealed class GithubRepo
 
  [JsonProperty("homepage")]
  public string Homepage { get; set; }
+
+ [JsonProperty("license")]
+ public GithubLicense License { get; set; }
+ }
+
+ public class GithubLicense
+ {
+ [JsonProperty("spdx_id")]
+ public string Id;
  }
 }

Netkan/Transformers/GithubTransformer.cs

@@ -66,6 +66,11 @@ public Metadata Transform(Metadata metadata)
  if (!string.IsNullOrWhiteSpace(ghRepo.Description))
  json.SafeAdd("abstract", ghRepo.Description);
 
+ // GitHub says NOASSERTION if it can't figure out the repo's license
+ if (!string.IsNullOrWhiteSpace(ghRepo.License?.Id)
+ && ghRepo.License.Id != "NOASSERTION")
+ json.SafeAdd("license", ghRepo.License.Id);
+
  if (!string.IsNullOrWhiteSpace(ghRepo.Homepage))
  resourcesJson.SafeAdd("homepage", ghRepo.Homepage);
 

Spec.md

@@ -648,6 +648,7 @@ For example: `#/ckan/github/pjf/DogeCoinFlag`.
 When used, the following fields will be auto-filled if not already present:
 
 - `name`
+- `license`
 - `abstract`
 - `author`
 - `version`