Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get license from GitHub #2663

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

HebaruSan
Copy link
Member

Motivation

The GitHub API provides license data:

https://api.github.com/repos/Starstrider42/Custom-Asteroids-Extras

  "license": {
    "key": "mit",
    "name": "MIT License",
    "spdx_id": "MIT",
    "url": "https://api.github.com/licenses/mit",
    "node_id": "MDc6TGljZW5zZTEz"
  },

But currently Netkan doesn't use this info.
We do use API license data from Curse and SpaceDock.

Changes

Now Netkan sets the API's license.spdx_id value to the module's license property.

Fixes #2662.

@HebaruSan HebaruSan added Enhancement Easy This is easy to fix Pull request Netkan Issues affecting the netkan data labels Jan 22, 2019
@politas politas merged commit 3b654eb into KSP-CKAN:master Jan 28, 2019
politas added a commit that referenced this pull request Jan 28, 2019
@HebaruSan HebaruSan deleted the feature/netkan-github-licenses branch January 28, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy This is easy to fix Enhancement Netkan Issues affecting the netkan data Pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants