Skip to content

Commit

Permalink
Merge #2493 Set default Exception.Message string for ModuleNotFoundKr…
Browse files Browse the repository at this point in the history
…aken
  • Loading branch information
politas committed Aug 22, 2018
2 parents b3d3bc9 + 536bb90 commit 86d1f57
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ All notable changes to this project will be documented in this file.
- [Multiple] Fix GUIMod crash when module doesn't have a compatible game version (#2486 by: HebaruSan; reviewed: cculianu, politas)
- [Core] Fix crash on invalid portable or Steam folder (#2506 by: HebaruSan; reviewed: politas)
- [GUI] Fix red X on HideTab (#2501 by: HebaruSan; reviewed: politas)
- [Core] Set default Exception.Message string for ModuleNotFoundKraken (#2493 by: HebaruSan; reviewed: politas)

## v1.25.2 (Goddard)

Expand Down
9 changes: 7 additions & 2 deletions Core/Types/Kraken.cs
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,17 @@ public class ModuleNotFoundKraken : Kraken
public string version;

// TODO: Is there a way to set the stringify version of this?
public ModuleNotFoundKraken(string module, string version = null, string reason = null, Exception innerException = null)
public ModuleNotFoundKraken(string module, string version, string reason, Exception innerException = null)
: base(reason, innerException)
{
this.module = module;
this.module = module;
this.version = version;
}

public ModuleNotFoundKraken(string module, string version = null)
: this(module, version, $"Module not found: {module} {version ?? ""}")
{ }

}

/// <summary>
Expand Down

0 comments on commit 86d1f57

Please sign in to comment.