Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default Exception.Message string for ModuleNotFoundKraken #2493

Merged
merged 1 commit into from
Aug 22, 2018
Merged

Set default Exception.Message string for ModuleNotFoundKraken #2493

merged 1 commit into from
Aug 22, 2018

Conversation

HebaruSan
Copy link
Member

Problem

When a ModuleNotFoundKraken exception is thrown without a description, the Exception.Message property is empty. This makes it harder to figure out what caused it.

Changes

Now ModuleNotFoundKraken will auto-generate a simple description if you don't pass one in:

Module not found: ModuleName v1.2.3.4

Fixes #1992.

@HebaruSan HebaruSan added Easy This is easy to fix Core (ckan.dll) Issues affecting the core part of CKAN Pull request labels Aug 8, 2018
@politas politas merged commit 536bb90 into KSP-CKAN:master Aug 22, 2018
politas added a commit that referenced this pull request Aug 22, 2018
@politas
Merge #2493 Set default Exception.Message string for ModuleNotFoundKr…
86d1f57 
…aken
@HebaruSan HebaruSan deleted the fix/modulenotfound-message branch August 22, 2018 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Easy This is easy to fix Pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HebaruSan @politas