Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow upgrades #16

Closed
pjf opened this issue Sep 24, 2014 · 2 comments
Closed

Allow upgrades #16

pjf opened this issue Sep 24, 2014 · 2 comments
Labels
Enhancement New features or functionality

Comments

@pjf
Copy link
Member

pjf commented Sep 24, 2014

At some point, people are going to want to upgrade their mods. There are two ways this is commonly done:

  • Delete everything, and unzip afresh.
  • Unzip in place.

The first means one knows exactly what one should end up with, the second means we can more easily preserve state generated by a previous install (although #15 provides a potential way of doing this).

We need to decide what the default behaviour is (right now it's unzip-in-place), but give the option to delete everything and unzip afresh.

@pjf pjf added Enhancement New features or functionality design labels Sep 24, 2014
@pjf
Copy link
Member Author

pjf commented Oct 4, 2014

Right now, upgrades don't work. You can't do them.

What we will be doing is:

  • Uninstall the previous version (except preserved files, see Preserved files #15)
  • Install the new one

This means mods have to be clear up-front about which files need to be kept between releases, and makes the upgrade process much more predictable.

I don't think we should allow unzip in place.

@pjf pjf changed the title Upgrades, how do they work? Add an upgrade command Oct 4, 2014
@pjf pjf changed the title Add an upgrade command Allow upgrades Oct 4, 2014
@pjf pjf added this to the Advanced Features. milestone Oct 4, 2014
@pjf pjf removed the design label Oct 4, 2014
@AlexanderDzhoganov
Copy link
Member

I have implemented this (except the preserved files part) in #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants