Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ckan ksp fake prints exception for future versions #2641

Closed
HebaruSan opened this issue Jan 8, 2019 · 0 comments
Closed

ckan ksp fake prints exception for future versions #2641

HebaruSan opened this issue Jan 8, 2019 · 0 comments
Labels
Bug Cmdline Issues affecting the command line

Comments

@HebaruSan
Copy link
Member

HebaruSan commented Jan 8, 2019

Background

CKAN Version:
421332c

KSP Version:
1.6

Operating System:
Win7

Have you made any manual changes to your GameData folder (i.e., not via CKAN)?
No

Problem

What steps did you take in CKAN?

Ran ckan ksp fake FAKETEST4 fake4 1.6.1 none

See #2627 for background on this command.

What did you expect to happen?

Either create a fake install with 1.6.1 in the readme.txt, or tell me that version 1.6.1 doesn't exist.

What happened instead?

System.ArgumentOutOfRangeException printed (twice).

As in #2640, we don't need a stack trace here, just a short message explaining why "1.6.1" isn't allowed.

And the final line is misleading, because the problem here isn't anything to do with the format.

CKAN error codes (if applicable):

240 [1] ERROR CKAN.CmdLine.KSP (null) - System.ArgumentOutOfRangeException: Your specified version is invalid.
Parameter name: version
   at CKAN.CmdLine.KSP.FakeNewKSPInstall(FakeOptions options)
System.ArgumentOutOfRangeException: Your specified version is invalid.
Parameter name: version
   at CKAN.CmdLine.KSP.FakeNewKSPInstall(FakeOptions options)
Examples for valid version formats: 1.5.0 | 1.5.1 | 1.6.0.2395
@HebaruSan HebaruSan added Bug Cmdline Issues affecting the command line labels Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Cmdline Issues affecting the command line
Projects
None yet
Development

No branches or pull requests

1 participant