Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@HebaruSan discovered some issues with my new two functions. This is how they behave now:
Both functions:
Write human-readable messages if there are too few arguments provided, no error messages due to crashes.
ckan ksp fake
:--set-default
flag to make the new instance the default afterwards.This logic is now added as a new method of
Versioning.KspVersion
->KspVersion RaiseVersionSelectionDialog(IUser)
.Note that, despite the IUser being passed, only the cmdline User and the consoleUI User implement a
RaiseSelectionDialog
, so it won't work in the GUI without implementing aRaiseSelectionDialog
.Thanks @HebaruSan for the idea.
Fixes #2641
Fixes #2640
Fixes #2639
Fixes #2638
Fixes #2637