Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hopeful contributions #1205

Closed
wants to merge 6 commits into from
Closed

Hopeful contributions #1205

wants to merge 6 commits into from

Conversation

martinnj
Copy link
Contributor

code related to:

Note: There is an oddity which occurs when you have a mod installed that have dependencies, and you click the new "deselect all". If you then reselect a mod that have dependencies, it does not install the mods since dependencies are not met.
I've been unable to find where dependencies are resolved, I think that logically it should be done in MarkModForInstall, however I do not see the current resolution logic there.

If you can point me where to implement it I will fix this myself.

Bug: When using deselect all and then reselect an item, it will
sometimes still appear as a remove task in the change list.
@pjf
Copy link
Member

pjf commented Jun 28, 2015

In the core, relationship resolution happens in the RelationshipResolver class, although I'm not personally familiar with how the GUI reaches that point, which is what I think you're after.

I'm working through as many PRs as I can today, so hopefully that includes this one, too (if nobody else gets to it first, which would be awesome).

Also while it's fine to pop all three changes into one PR, we love it even more when they come in separate PRs. That makes reviewing much easier, gives us a nicer changelog (each merge into master usually results in a release notes entry), and means issues with one change doesn't block any others.

Thank you so much again for this. And if you haven't found us on #ckan on irc.esper.net, you should. :)

@martinnj
Copy link
Contributor Author

I was on the IRC a couple of hours last night (EU time) was a quiet place at the time.

I'll close this PR, do some voodoo to my fork and create a bunch of new PRs instead.

@martinnj martinnj closed this Jun 28, 2015
@pjf pjf removed the Pull request label Jun 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants