Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(De)select all button #1148

Closed
RichardLake opened this issue Jun 22, 2015 · 7 comments · Fixed by #1211 or #2596
Closed

(De)select all button #1148

RichardLake opened this issue Jun 22, 2015 · 7 comments · Fixed by #1211 or #2596
Labels
Easy This is easy to fix Enhancement GUI Issues affecting the interactive GUI ★☆☆

Comments

@RichardLake
Copy link
Contributor

It would be useful to have a button to select/deselect all the mods on the recommend and suggests screens.

@RichardLake RichardLake added Enhancement Easy This is easy to fix GUI Issues affecting the interactive GUI ★☆☆ labels Jun 22, 2015
@Postremus
Copy link
Contributor

such a button is everywhere usefull. for example, when you want to deinstall all installed mods.

@RichardLake RichardLake changed the title (De)select all button on recommandation screen (De)select all button Jun 22, 2015
@RichardLake
Copy link
Contributor Author

#1211 Adds a delectect all button to the main mod list not the recommends/suggests window.

@RichardLake RichardLake reopened this Jun 28, 2015
martinnj added a commit to martinnj/CKAN that referenced this issue Aug 15, 2015
Adds menu items for "selecting all installed" and "deselect all
selected". Also adds a checkbox to the recommended/suggested mods page
for toggling all mods in the list. Implements KSP-CKAN#1148.
@mheguy
Copy link
Contributor

mheguy commented May 23, 2016

We now have a (de)select all button available for recommends and suggests. We don't have one available in the main mod screen because:

  1. wanting to uninstall all mods is very uncommon and we would be better served by a button/function that does explicitly that
  2. it's not possible to use it in a "select all" context as you would inevitably create conflicts when trying to install every mod
  3. a (de)select all button would almost certainly be mistaken for a "revert all install/uninstall changes" button where a user expects their currently installed mods to remain intact.

With all that established, closing this but certainly open to the idea of a "uninstall all"-type option.

@mheguy mheguy closed this as completed May 23, 2016
@politas
Copy link
Member

politas commented May 24, 2016

Select All could be useful if applied to a filtered list based on the "filter by" fields.

@mheguy
Copy link
Contributor

mheguy commented May 24, 2016

Can only speak for my own habits, but I usually filter with a single mod in mind. That said I don't represent everyone, so re-opening.

@mheguy mheguy reopened this May 24, 2016
@politas
Copy link
Member

politas commented May 24, 2016

I can easily see someone deciding they want all of Roverdude's mods, for instance - They generally make a useful combined set.

@ayan4m1
Copy link
Contributor

ayan4m1 commented Jul 31, 2016

Yes, I would use this with the filter box to select small batches of mods at once using a common search term. I understood that it wasn't trivial to add to this app in particular, but I was missing the ability to find 10 mods and check them all at once.

If you wanted to "uninstall all" then you'd set the filter type to be Installed and then hit the "deselect all shown" button.

From a UI perspective I think changing the "Installed" column to have a checkbox would keep things small. It also means the "de-select all" checkbox can go away assuming the two tabs are using the same grid control.

I think the workaround for the "trying to change the dependency tree state too much at once" issue will be to uncheck each item individually and allow the state to settle without enforcing deps, but that will probably decrease the speed/efficiency of the operation and I haven't looked at the ckan.dll API much yet.

I don't want to bring an opinionated pull request so I am hoping to get a little more feedback from everyone using my half-baked ideas at solving this as a lightning rod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy This is easy to fix Enhancement GUI Issues affecting the interactive GUI ★☆☆
Projects
None yet
5 participants