Bulk selection features added. #1383
Conversation
Adds menu items for "selecting all installed" and "deselect all selected". Also adds a checkbox to the recommended/suggested mods page for toggling all mods in the list. Implements KSP-CKAN#1148.
|
Using closes/fixes/resolves will have GitHub automatically close issues when a PR is merged. |
| //ApplyToolButton.Enabled = true; | ||
| } | ||
| } | ||
| ApplyToolButton.Enabled = (ChangeSet.Any()); |
There was a problem hiding this comment.
Got an exception in this line: (Changeset was null)
An unhandled exception of type 'System.ArgumentNullException' occurred in System.Core.dll
Additional information: Der Wert darf nicht NULL sein.
bei System.Linq.Enumerable.Any[TSource](IEnumerable`1 source)
bei CKAN.Main.deselectAllSelectedModsToolStripMenuItem_Click(Object sender, EventArgs e) in C:\Users\Martin\Documents\Visual Studio 2015\Projects\CKAN\GUI\Main.cs:Zeile 1066.
bei System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
bei System.Windows.Forms.ToolStripMenuItem.OnClick(EventArgs e)
bei System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
bei System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
bei System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
bei System.Windows.Forms.ToolStripDropDown.OnMouseUp(MouseEventArgs mea)
bei System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
bei System.Windows.Forms.Control.WndProc(Message& m)
bei System.Windows.Forms.ToolStrip.WndProc(Message& m)
bei System.Windows.Forms.ToolStripDropDown.WndProc(Message& m)
bei System.Windows.Forms.NativeWindow.DebuggableCallback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
bei System.Windows.Forms.UnsafeNativeMethods.DispatchMessageW(MSG& msg)
bei System.Windows.Forms.Application.ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(IntPtr dwComponentID, Int32 reason, Int32 pvLoopData)
bei System.Windows.Forms.Application.ThreadContext.RunMessageLoopInner(Int32 reason, ApplicationContext context)
bei System.Windows.Forms.Application.ThreadContext.RunMessageLoop(Int32 reason, ApplicationContext context)
bei CKAN.Main..ctor(String[] cmdlineArgs, GUIUser User, Boolean showConsole) in C:\Users\Martin\Documents\Visual Studio 2015\Projects\CKAN\GUI\Main.cs:Zeile 223.
bei CKAN.GUI.Main_(String[] args, Boolean showConsole) in C:\Users\Martin\Documents\Visual Studio 2015\Projects\CKAN\GUI\Program.cs:Zeile 35.
bei CKAN.GUI.Main(String[] args) in C:\Users\Martin\Documents\Visual Studio 2015\Projects\CKAN\GUI\Program.cs:Zeile 17.
bei System.AppDomain._nExecuteAssembly(RuntimeAssembly assembly, String[] args)
bei System.AppDomain.ExecuteAssembly(String assemblyFile, Evidence assemblySecurity, String[] args)
bei Microsoft.VisualStudio.HostingProcess.HostProc.RunUsersAssembly()
bei System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
bei System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
bei System.Threading.ThreadHelper.ThreadStart()
|
The Checkbox and the caption are not aligned properly in the recommends / suggested dialog |
|
Both bugs are corrected now. Thanks for bringing it up 👍 |
|
I deselected all mods. Apply changes is Grey. |
|
I'm unable to recreate that on my PC. Logically the status of the botton after "deselect all" is decided by the state of the "ChangeSet", if the set is null or have less than 1 item, it will be disabled, otherwise it will be enabled. Did you have any mods installed when you did the test or what was the status? |
|
35 mods installed: |
|
As a recommends list: http://puu.sh/jCylF/bc0c9fdde4.ckan |
Prevents inconsistency errors due to dependencies being marked for uninstall before the dependant.
|
Maybe you could split this PR into two? One could contain the changes to the recommends page, the other one the changes to the main mod list. |
|
Will do, created a new pr (#1398) for the checkbox. :) |
|
My apologies I've been a little while jumping in here. This is awesome and seems to be working for me under Linux, but it looks like I've managed to find a tiny bug, where the (de-)select all ticky may start off in the opposite state to everything else:
In this case, I was installing the "CrowdSourcedFlags" mod, which suggests a bunch of other flags. (Steps to reproduce: Open CKAN, select CrowdSourcedFlags, hit apply chages, hit next to get to get to suggesed mods.) I don't know if it's possible, but having the ticky start ticked for recommends, and unticked for suggested would be great! (And some mods may only have recommends, and others may only have suggests.) A merge or rebase will also assist in merging, but is not strictly necessary as I can do that if needed. :) Many, many thanks! ~ Paul |
|
I can create a patch for the checkbox state, It's just a question of making sure it's unchecked whenever I also change the label text. Might not have to create it before next week if it has any interest? |
|
Got it, awesome :) |
|
Oh no, I've reached that point where I'm completely confused about this PR again! To help me out:
|
|
There is still some GUI changes left. But since I have been unable to recreate the bug Postremus descovered and been busy as fuck I have yet to fix anything. I most likely won't have time to fix it up since my courses have started back up. Sorry. |
Adds menu items for "selecting all installed" and "deselect all
selected". Also adds a checkbox to the recommended/suggested mods page
for toggling all mods in the list. Implements #1148.