Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently if you have an invalid
$kref
:The error message isn't super clear:
Here it's telling us that it doesn't have a
download
property, which is indeed caused by the$kref
being invalid, but it's rather indirect and not necessarily clear to a new user.Changes
Now the
NetkanValidator
has a new validation step that checks whethermetadata.Kref.Source
is a known valid value (null is also OK). If not, it prints a new error message:RemoteRef.ToString
previously dropped the/ckan/
portion of the original string;#/ckan/techman/iscool
became#/techman/iscool
. To reduce confusion, this function now preserves the original string.Fixes #374.