Prompt for client upgrade when newer spec is found #4026
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CkanModule.spec_version
property allows us to handle backwards incompatible changes to metadata; if it is greater than your client version for a module, then that module is hidden. When this happens, it is not apparent to the user, and users sometimes ask us or mod authors why a mod version is missing.Changes
CkanModule.IsSpecSupported
retrieves the version from the executing assembly and parses it every single time, which is probably a small amount of wasted work, but might add up over a thousand-plus modules. This is now replaced by a public static variable that's only parsed once.Fixes #3994.