Fix outdated client message when up to date #4057
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The new "Repositories updated, but found modules that require a new version of CKAN. Checking for updates..." message appears on every update, regardless of whether your client is outdated.
Cause
In #4026 we treated an
ArchiveEntry
tuple as indicating an unsupported spec version if its first item was null, but this is also expected fordownload_counts.json
,builds.json
, andrepositories.json
. The correct indicator is when all of the first four items are null.Changes
Now we check whether all of the first four items in the tuple are null.