Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Freezer #303

Merged
merged 4 commits into from
Apr 21, 2023
Merged

Auto Freezer #303

merged 4 commits into from
Apr 21, 2023

Conversation

techman83
Copy link
Member

@techman83 techman83 commented Apr 21, 2023

This is a tweak to the auto-freezer, as we're hitting some different limits as KSP ages, and more effort heading to KSP2

Fixes

  • Force a deep clone, fixing branch switching
  • Commit and pause during batched freezing to avoid WCU limits of DynamoDB
  • Freeze process not filtering for game_id

Changes

  • Increase memory for the auto freezer

Fixes #302.

It is possible the branches have drifted enough in a week that a shallow clone will result in
the branch switch not working. Being a weekly operation, a deep clone is acceptable here.

Also noted memory use was close to the limit, bumped to 156 as we have spare capacity.

    Fixes KSP-CKAN#302
We use a limited WCU to keep within the DynamoDB free tier. It in general more than covers our
very minimal needs. However this operation will exceed if there a large number of writes to
commit as the batch has no rate limiting and will occur on context exit if not done during.
Copy link
Member

@HebaruSan HebaruSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I would still like to know why the bot's pull request comment never appears, though.

The freeze run for KSP2 attemped to freeze a bunch of non-ksp2 games when it finally ran
successfully. This ensures the correct game is scanned
@HebaruSan HebaruSan added Bug Something isn't working Auto Freezer Finds idle mods and submits pull requests to freeze them labels Apr 21, 2023
There is no discernable reason why the autofreezer comments are not appearing. Hopefully
some logging will help
@techman83
Copy link
Member Author

Added some extra logging for the comment.

@techman83 techman83 merged commit 8bd2c76 into KSP-CKAN:master Apr 21, 2023
@techman83 techman83 deleted the fix/auto-freezer branch April 21, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto Freezer Finds idle mods and submits pull requests to freeze them Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoFreezer fails to re-use branch and PR
2 participants