Use deep clone for SpaceDockAdder #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
|
... oh right, changes to |
|
I was going to do this, but was feeling a bit under the weather. Thanks @HebaruSan - I'll nudge this out shortly! |
|
Oh no, get well soon! 🤒 ... and that worked! 🎉 KSP-CKAN/NetKAN#9778 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We've been getting spammed by these every 5 minutes:
Cause
The CKAN checkbox came unchecked for this mod on SpaceDock, so I re-checked it, which caused the webhooks to put an entry into the
SpaceDockAdder's input queue for it.The
SpaceDockAdderthen fails to process it, leaves it in the queue, and tries again in 5 minutes. This happens because KSP-CKAN/NetKAN#9778 is still open and its branch still exists, so the adder fails to push the branch, because it's using a shallow clone.This is the same problem that the
AutoFreezerwas having in #302.Changes
Just like #303 did for the
AutoFreezer, theSpaceDockAddernow uses a deep clone, which will allow it to re-use existing branches.