Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertise install filters in ZeroMiniAVC, fix BetterSRBs name #10230

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Sep 25, 2024

Problems

  • The name of BetterSRBs looks weird, with a space between the R and the B
    image
  • Discord user dan reported frequent prompts from the dev build to reinstall mods after running the game, which said "metadata changed" even though the metadata for those mods had either never changed or changed over two years previously

Causes

Changes

  • Now BetterSRBs has a hard coded name of Better SRBs
  • Now the abstract of ZeroMiniAVC instructs users how to access the settings from Global install filters CKAN#3458, so users who wish to banish MiniAVC can discover the optimal way of doing that:
    image
    (A subsequent pull request in the CKAN repo will improve other aspects of usability for users who encounter this ZeroMiniAVC reinstallation cycle.)

I'm going to attempt to clear the second part of this with @linuxgurugamer before merging (reached out via Discord PM and forum PM).

@JonnyOThan
Copy link
Contributor

Would it be slightly better to filter mini-avc in the .netkans of mods that bundle it, and then make them recommend/depend on mini-avc as a separate mod?

OR somehow make an exception in the "missing files" logic for mini-avc stuff (I'm sure there are going to be other examples of mods that intentionally delete files after installation, similar to WBI though we already have a system for that).

@HebaruSan
Copy link
Member Author

HebaruSan commented Sep 26, 2024

No, I don't think that would be better. If I did, I would have done that instead.

@HebaruSan
Copy link
Member Author

HebaruSan commented Sep 26, 2024

Heard back from @linuxgurugamer via Discord PM. He is OK with this as long as we limit the scope to note that ZeroMiniAVC may still have some usefulness for users with manually installed mods, as done in the latest commit.

@HebaruSan HebaruSan merged commit 1e10d8d into KSP-CKAN:master Sep 26, 2024
1 check passed
@HebaruSan HebaruSan deleted the update/zerominiavc-abstract branch September 26, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants