-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: migrate to GitHub Actions from CircleCI, allow running Browserstack on forked repo via label #2417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was fast. Thanks for moving us over to GitHub Actions.
Why did the coverage report change so drastically? I wouldn't expect any change in those numbers from this PR. |
This comment has been minimized.
This comment has been minimized.
It seems the codecov-action is uploading |
@ylemkimon do you need my help with any of the checkbox items at the top? |
@kevinbarabash No, they are to-dos after this PR is merged. |
In that case I better review this. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for migrating CircleCI stuff to GitHub Actions. It'll be nice to have all of the CI workflows using the same system. Was #2418 a test for this PR? If so, wouldn't the base of that PR need to be the head of this one? I think it would be good to also do a PR from a fork to test that flow. Also, more comments especially for some of the if
statements in the ci.yml will be helpful if other people need to look at the file in the future.
|
||
steps: | ||
- id: set-matrix | ||
uses: actions/github-script@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This docs for this action say that it's possible to require external scripts. If we did that we could lint the script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevinbarabash The repo has to be checked out in order to run the script on the repo. However, this job doesn't check out the repo, and adding checkout
will increase the time by about 5 seconds, where this job takes only 1-2 seconds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize that. That's good to know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevinbarabash I'm creating a ESLint plugin, which lints JavaScript in GitHub Actions workflow. I'll enable it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There are a couple of more places in ci.yml that could use comments before merging this, see inline comments for details.
@kevinbarabash Thank you for the review! I've confirmed they work as intended in #2429. Could you stop CircleCI builds in https://app.circleci.com/settings/project/github/KaTeX/KaTeX? |
I've stopped the CircleCI builds. |
Exciting! Nice work. |
From #2415: