-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support AMS log-like symbols #2429
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2429 +/- ##
==========================================
+ Coverage 93.97% 94.01% +0.03%
==========================================
Files 84 84
Lines 5444 5476 +32
Branches 961 964 +3
==========================================
+ Hits 5116 5148 +32
Misses 297 297
Partials 31 31
Continue to review full report at Codecov.
|
Oh, I forgot to list the symbol names. They are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think the documentation part of this could be tweaked a bit. See inline comments before merging.
defineMacro("\\injlim", "\\DOTSB\\operatorname*{int\\,lim}"); | ||
defineMacro("\\projlim", "\\DOTSB\\operatorname*{proj\\,lim}"); | ||
defineMacro("\\varlimsup", "\\DOTSB\\operatorname*{\\overline{lim}}"); | ||
defineMacro("\\varliminf", "\\DOTSB\\operatorname*{\\underline{lim}}"); | ||
defineMacro("\\varinjlim", "\\DOTSB\\operatorname*{\\underrightarrow{lim}}"); | ||
defineMacro("\\varprojlim", "\\DOTSB\\operatorname*{\\underleftarrow{lim}}"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it.
docs/supported.md
Outdated
|
||
Functions on the right column of this table can take `\limits`. | ||
Functions in the right column and bottom three rows of this table can take `\limits`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can \argmax
take limits as well?. Maybe an asterisk or something to indicate which items can take \limits
would be easier to maintain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know, I should review this table and that statement about the right hand column. I wrote that statement many revisions ago and I am no longer positive that it is still true. I'll spend some time with it tomorrow.
I once considered asterisks, but that would be confusing since asterisks are a part of some LaTeX functions, like \operatorname*
. So far, I have not thought of any better way to convey the limits
idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll mark this PR as a draft for further changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have revised the Math Operators table in the documentation. This PR is once again ready for review.
This is super exciting. We still load MathJax as a fallback on khanacademy.org. I'll be nice to only load KaTeX. 🙂 |
This PR checks off six items in the effort to reach function parity with MathJax. That list is dwindling.
Here's a screenshot:
... which compares to the same code in quicklatex.com: