replay fix + stage, gf and noteStyle defaults to their corresponding style if none was found in chart #824
Conversation
|
Adds #820 |
replay 1.1 still has 1.0 support
Lucky-56
changed the title
|
Fixes #825 |
|
would be funny if you sqeezed this into 1.5.2 aswell (as the current pre-compiled version is broken) |
as in for modders to copy paste easily
| case 5: if (songLowercase == 'winter-horrorland') {stageCheck = 'mallEvil';} else {stageCheck = 'mall';} | ||
| case 6: if (songLowercase == 'thorns') {stageCheck = 'schoolEvil';} else {stageCheck = 'school';} | ||
| //i should check if its stage (but this is when none is found in chart anyway) | ||
| } |
There was a problem hiding this comment.
Should also be applying gfVersion and noteStyle because of weeks 4-6.
|
i swear to god im about to make a github action that comments on every pr saying to actually test it when approving changes and not just glance over them |
Lucky-56
changed the title
Lucky-56
changed the title
what do you mean by that |
|
In gameplay, B-Sides works as intended with the stage, gf, and notes. However in replay, it defaults back to stage, regular gf, and regular notes. |
|
I currently have a problem understanding why, cause the replay just loads the JSON associated with the song name and that should load the stage'n'stuff right? |
|
I found the culprit when starting a replay it doesn't get the week correctly EDIT: haha found it it is as simple as removing |
just took an extra \n at the end for some reason
|
actually tested these this time |
|
Fixes #830 |
REOPENED: #824 replay fix + modchart fix + stage, gf and noteStyle defaults to their corresponding style if none was found in chart
No description provided.