Skip to content

Commit

Permalink
test: fix failing test due to change in the use of the icon property
Browse files Browse the repository at this point in the history
  • Loading branch information
ju-Skinner committed Jan 10, 2024
1 parent c57a515 commit 46929a2
Show file tree
Hide file tree
Showing 5 changed files with 782 additions and 628 deletions.
2 changes: 1 addition & 1 deletion libs/core/.gitignore
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
dist/
www/
loader/
components/
/components/

scripts/**/*.js

Expand Down
2 changes: 1 addition & 1 deletion libs/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"test.watch": "stencil test --spec --e2e --watchAll --coverage"
},
"dependencies": {
"@pine-ds/icons": "3.3.0",
"@pine-ds/icons": "^3.4.0",
"@stencil/core": "^4.8.1",
"sortablejs": "^1.15.0"
},
Expand Down
4 changes: 2 additions & 2 deletions libs/core/src/components/pds-link/test/pds-link.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ describe('pds-link', () => {
html: `<pds-link href="#" external="true"></pds-link>`,
});

const externalIcon = root?.shadowRoot?.querySelector('pds-icon[name="launch"]');
expect(externalIcon).not.toBeNull();
const externalIcon = root?.shadowRoot?.querySelectorAll('pds-icon');
expect(externalIcon?.length).toBe(1)
});

it('renders class name when size is assigned', async () => {
Expand Down
2 changes: 1 addition & 1 deletion libs/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
},
"dependencies": {
"@pine-ds/core": "^0.0.2-alpha.1",
"@pine-ds/icons": "3.3.0"
"@pine-ds/icons": "3.4.0"
},
"devDependencies": {
"@rollup/plugin-typescript": "^11.1.5",
Expand Down
Loading

0 comments on commit 46929a2

Please sign in to comment.