Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSS-462] add Popover #134

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[DSS-462] add Popover #134

wants to merge 2 commits into from

Conversation

QuintonJason
Copy link
Contributor

Description

  • added the Popover component

Fixes #DSS-462

Screen Shot 2023-09-11 at 10 23 24 AM

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests you've added and run to verify your changes.
Provide instructions so that we can reproduce.
Please also list any relevant details for your test configuration.

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Test Configuration:

  • Pine versions:
  • OS:
  • Browsers:
  • Screen readers:
  • Misc:

Checklist:

If not applicable, leave options unchecked.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit a04782e
🔍 Latest deploy log https://app.netlify.com/sites/pine-design-system/deploys/65de1bd211142700087df469
😎 Deploy Preview https://deploy-preview-134--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added enhancement New feature or request package: core Changes have been made to the Core package package: react Changes have been made to the React package labels Jan 23, 2024
@QuintonJason QuintonJason mentioned this pull request Jan 23, 2024
16 tasks
@QuintonJason QuintonJason marked this pull request as draft January 23, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request package: core Changes have been made to the Core package package: react Changes have been made to the React package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants