[DSS-462] add Popover #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pine-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
package: core
pixelflips
requested changes
Sep 12, 2023
libs/core/src/components/pds-popover/stories/pds-popover.stories.js
Outdated
Show resolved
Hide resolved
pixelflips
reviewed
Sep 12, 2023
libs/core/src/components/pds-popover/stories/pds-popover.docs.mdx
Outdated
Show resolved
Hide resolved
ju-Skinner
reviewed
Sep 13, 2023
❌ Deploy Preview for pine-icons failed.
|
ju-Skinner
force-pushed
the
next
branch
2 times, most recently
from
4bda89a
to
cc05124
Compare
…ltip to pds-popover
…for overlay action list content
Co-authored-by: Monica Wheeler <monica.wheeler@kajabi.com>
Co-authored-by: Monica Wheeler <monica.wheeler@kajabi.com>
pixelflips
requested changes
Dec 4, 2023
|
|
||
| expect(element?.querySelector('.pds-popover')).toHaveClass('pds-popover--is-open'); | ||
| }); | ||
| it('should toggle the popover', async () => { |
pixelflips
approved these changes
Dec 4, 2023
| <pds-button variant="secondary">Help</pds-button> | ||
| </pds-popover>`; | ||
|
|
||
| const AvatarDropdownTemplate = (args) => html` |
There was a problem hiding this comment.
Maybe as a follow up at some point we could change this story to something like Trigger or Trigger Types? I found Avatar Popover in the sidebar confusing initially and thought it was some type of variant. Not a major blocker, just felt it's worth a mention.
ju-Skinner
force-pushed
the
next
branch
3 times, most recently
from
5f89487
to
46929a2
Compare
|
Closing in favor of #134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #DSS-462
Type of change
How Has This Been Tested?
Please describe the tests you've added and run to verify your changes.
Provide instructions so that we can reproduce.
Please also list any relevant details for your test configuration.
Test Configuration:
Checklist:
If not applicable, leave options unchecked.