fix(security): addresses vulnerability identified by snyk #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voodooGQ
approved these changes
Aug 22, 2022
ju-Skinner
force-pushed
the
SAGE-421/snyk-lodash-vulnerability
branch
from
50728d1
to
be1388c
Compare
there was a security concern with the previous lodash version. Needed to upgrade @babel/preset-env to resolve
ju-Skinner
force-pushed
the
SAGE-421/snyk-lodash-vulnerability
branch
from
be1388c
to
1e1e551
Compare
|
@Kajabi/ux-devs I asked you for your review here due to the changes in this commit. I had to fix the lint errors caused by the previous commit to override |
ju-Skinner
commented
Aug 22, 2022
| @@ -61,7 +61,7 @@ export const MultipleRadios = (args) => { | |||
| <Radio | |||
| {...args} | |||
| id={`check-${i}`} | |||
| key={i.toString()} | |||
There was a problem hiding this comment.
Note: It is not recommended to use an Array index for a key.
https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-array-index-key.md
ju-Skinner
commented
Aug 22, 2022
| @@ -148,7 +148,7 @@ Description.propTypes = { | |||
| className: PropTypes.string, | |||
| items: PropTypes.arrayOf(PropTypes.shape({ | |||
| action: PropTypes.shape({ | |||
| attributes: PropTypes.objectOf(PropTypes.object), | |||
There was a problem hiding this comment.
ju-Skinner
commented
Aug 22, 2022
| @@ -95,7 +95,7 @@ export const Carousel = ({ | |||
| disabled={arrowNextDisabled} | |||
| icon="caret-right" | |||
| id="next" | |||
| onClickCallback={handleNextArrowClick} | |||
There was a problem hiding this comment.
Note: JSX props should not use functions
https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-no-bind.md
voodooGQ
approved these changes
Aug 23, 2022
|
LGTM. |
Mark-Miller-Kajabi
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
https://kajabi.atlassian.net/browse/SAGE-421
Description
there was a security concern with the previous lodash version we were using. Needed to upgrade @babel/preset-env
to resolve