Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security): addresses vulnerability identified by snyk #1540

Merged
merged 4 commits into from
Aug 24, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"@commitlint/config-conventional": "^11.0.0",
"commitizen": "^4.2.2",
"dotenv": "8.2.0",
"eslint": "^7.10.0",
"eslint": "7.32.0",
"handlebars": "^4.7.7",
"lerna": "^3.22.1",
"lodash": "^4.17.21",
Expand Down
5 changes: 3 additions & 2 deletions packages/sage-react/lib/Breadcrumbs/Breadcrumbs.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,11 @@ export const Breadcrumbs = ({
</Link>
);

const breadCrumbItemKey = `breadcrumbItem-${i.toString()}`;
return items.length === 1 ? (
<p key={i.toString()} className="sage-breadcrumbs__item">{content}</p>
<p key={breadCrumbItemKey} className="sage-breadcrumbs__item">{content}</p>
) : (
<li key={i.toString()} className="sage-breadcrumbs__item">{content}</li>
<li key={breadCrumbItemKey} className="sage-breadcrumbs__item">{content}</li>
);
});

Expand Down
4 changes: 2 additions & 2 deletions packages/sage-react/lib/Carousel/Carousel.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ export const Carousel = ({
disabled={arrowPrevDisabled}
icon="caret-left"
id="prev"
onClickCallback={handlePrevArrowClick}
onClickCallback={() => handlePrevArrowClick}
/>
<div className="sage-carousel__sizer">
<div className="sage-carousel__carousel">
Expand All @@ -95,7 +95,7 @@ export const Carousel = ({
disabled={arrowNextDisabled}
icon="caret-right"
id="next"
onClickCallback={handleNextArrowClick}
Copy link
Collaborator Author

@ju-Skinner ju-Skinner Aug 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onClickCallback={() => handleNextArrowClick}
/>
</div>
{!looping && (
Expand Down
2 changes: 1 addition & 1 deletion packages/sage-react/lib/Description/Description.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ Description.propTypes = {
className: PropTypes.string,
items: PropTypes.arrayOf(PropTypes.shape({
action: PropTypes.shape({
attributes: PropTypes.objectOf(PropTypes.object),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attributes: PropTypes.objectOf(PropTypes.object()),
iconOnly: PropTypes.bool,
value: PropTypes.string,
}),
Expand Down
2 changes: 1 addition & 1 deletion packages/sage-react/lib/Toggle/Checkbox.story.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export const MultipleCheckboxes = (args) => {
{...args}
id={`check-${i}`}
itemInList={true}
key={i.toString()}
key={`check-${i.toString()}`}
onChange={onChange}
name="group-1"
{...configs}
Expand Down
2 changes: 1 addition & 1 deletion packages/sage-react/lib/Toggle/Radio.story.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export const MultipleRadios = (args) => {
<Radio
{...args}
id={`check-${i}`}
key={i.toString()}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key={`check-${i.toString()}`}
onChange={onChange}
name="group-1"
itemInList={true}
Expand Down
2 changes: 1 addition & 1 deletion packages/sage-react/lib/Toggle/Switch.story.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export const MultiplesExample = (args) => {
<Switch
id={`switch-${i}`}
itemInList={true}
key={i.toString()}
key={`switch-${i.toString()}`}
name="group-1"
onChange={onChange}
type={args.type}
Expand Down
5 changes: 4 additions & 1 deletion packages/sage-system/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,13 @@
},
"gitHead": "b8c2dd5f156473667f33a4d425c501a1e3b1c578",
"dependencies": {
"@babel/preset-env": "^7.11.5",
"@babel/preset-env": "^7.18.10",
"arrive": "^2.4.1",
"babel-loader": "^8.1.0",
"sortablejs": "^1.12.0",
"tiny-slider": "^2.9.4"
},
"overrides": {
"path-parse": "^1.0.7"
}
}
11,181 changes: 4,558 additions & 6,623 deletions yarn.lock

Large diffs are not rendered by default.