-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(security): addresses vulnerability identified by snyk #1540
Changes from all commits
a245e9e
df394d9
c9c5902
1e1e551
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -148,7 +148,7 @@ Description.propTypes = { | |
className: PropTypes.string, | ||
items: PropTypes.arrayOf(PropTypes.shape({ | ||
action: PropTypes.shape({ | ||
attributes: PropTypes.objectOf(PropTypes.object), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
attributes: PropTypes.objectOf(PropTypes.object()), | ||
iconOnly: PropTypes.bool, | ||
value: PropTypes.string, | ||
}), | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,7 +61,7 @@ export const MultipleRadios = (args) => { | |
<Radio | ||
{...args} | ||
id={`check-${i}`} | ||
key={i.toString()} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note: It is not recommended to use an Array index for a key. |
||
key={`check-${i.toString()}`} | ||
onChange={onChange} | ||
name="group-1" | ||
itemInList={true} | ||
|
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: JSX props should not use functions
https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-no-bind.md