Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAGE-754 - Icon: Add "NULL" icon for placeholder needs #1567

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

goodwinchris
Copy link
Contributor

@goodwinchris goodwinchris commented Aug 23, 2022

Description

Addition of empty null icon to act as a placeholder for instances where icon spacing is needed but no icon is expected.

Screenshots

Rails React
CleanShot 2022-08-23 at 10 55 37@2x CleanShot 2022-08-23 at 10 33 53@2x

Testing in sage-lib

http://localhost:4000/pages/foundations/icon
http://localhost:4100/?path=/docs/sage-icon--null-icon

Testing in kajabi-products

  1. (LOW) Addition of new empty null icon
    • Change should be benign

Related

SAGE-754 - Icon: Add "NULL" icon for placeholder needs

@goodwinchris goodwinchris self-assigned this Aug 23, 2022
@goodwinchris goodwinchris force-pushed the SAGE-754/cg_add-null-icon branch from 7d9c9c6 to f1fcdb2 Compare August 23, 2022 14:43
@goodwinchris goodwinchris requested review from a team August 23, 2022 14:51
@goodwinchris goodwinchris marked this pull request as ready for review August 23, 2022 14:51
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

Copy link
Contributor

@QuintonJason QuintonJason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition

Copy link
Contributor

@philschanely philschanely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@goodwinchris goodwinchris merged commit 9a04418 into develop Aug 24, 2022
@goodwinchris goodwinchris deleted the SAGE-754/cg_add-null-icon branch August 24, 2022 14:46
@goodwinchris goodwinchris mentioned this pull request Aug 24, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants