Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAGE-754 - Icon: Add "NULL" icon for placeholder needs #1567

Merged
merged 1 commit into from
Aug 24, 2022
Merged

SAGE-754 - Icon: Add "NULL" icon for placeholder needs #1567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion docs/app/views/examples/components/icon/_props.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@
</tr>
<tr>
<td><%= md('`icon`') %><%= sage_component SageBadge, { color: "published", value: "required" } %></td>
<td><%= md('Which icon to display. See Sage Icons under "Design."') %></td>
<td><%= md('
Which icon to display. See Sage Icons under "Figma Design."
Note: `null` is also available to place an empty space icon
') %></td>
<td><%= md('`String` for desired icon.') %></td>
<td><%= md('--') %></td>
</tr>
Expand Down
1 change: 1 addition & 0 deletions docs/lib/sage_rails/app/sage_tokens/sage_tokens.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,7 @@ def SageTokens.grid_templates
"move-right",
"multi-pay",
"newsletter",
"null",
"one-off-session",
"one-time",
"package",
Expand Down
1 change: 1 addition & 0 deletions packages/sage-assets/lib/stylesheets/tokens/_icon.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ $sage-icons: (
move-right: unicode(e99a),
multi-pay: unicode(e99b),
newsletter: unicode(e99c),
"null": "",
one-off-session: unicode(e99d),
one-time: unicode(e99e),
package: unicode(e99f),
Expand Down
7 changes: 7 additions & 0 deletions packages/sage-react/lib/Icon/Icon.story.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,10 @@ CustomBackgroundSizeCircular.args = {
backgroundHeight: '48px',
size: Icon.SIZES.LG
};
export const NullIcon = Template.bind({});
NullIcon.args = {
cardColor: 'draft',
circular: true,
backgroundHeight: '48px',
icon: Icon.ICONS.NULL,
};
1 change: 1 addition & 0 deletions packages/sage-react/lib/configs/tokens/icons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ export const TOKENS_ICONS = {
MOVE_RIGHT: 'move-right',
MULTI_PAY: 'multi-pay',
NEWSLETTER: 'newsletter',
NULL: 'null',
ONE_OFF_SESSION: 'one-off-session',
ONE_TIME: 'one-time',
PACKAGE: 'package',
Expand Down