Pagination: Single-page behavior, style, and window prop updates
#1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove :hover styles where no longer needed - Update color values - Add round border radius
philschanely
changed the title
window prop updates
pixelflips
approved these changes
Sep 7, 2022
| @@ -55,6 +55,6 @@ | |||
| <tr> | |||
| <td><%= md('`window`') %></td> | |||
| <td><%= md('Sets the number of items on either side of the `...` item. (Note: the left side will be `window` + 1). Has no affect when `hide_pages` is set to true.') %></td> | |||
| <td><%= md('String') %></td> | |||
| <td><%= md('`nil`') %></td> | |||
| <td><%= md('Number') %></td> | |||
| <%= component.generated_html_attributes.html_safe %> | ||
| > | ||
| <% if !component.hide_counter %> | ||
| <span class="sage-pagination__count <%= "sage-pagination__count--solo" if component.items.total_pages == 1 %>"> |
There was a problem hiding this comment.
🧛🏼 count solo... made me laugh, def not a show-stopper. sorry back to the serious review.
ju-Skinner
reviewed
Sep 8, 2022
| aria-label="Pagination Navigation" | ||
| <%= component.generated_html_attributes.html_safe %> | ||
| > | ||
| <% if !component.hide_counter %> |
There was a problem hiding this comment.
preferred in ruby unless component.hide_counter
ju-Skinner
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates how Pagination behaves when there is only one page and a few styles to sync with latest spec including:
Screenshots
windowin Rails and updates documentation accordinglyTesting in
sage-libSee Components > Pagination
Testing in
kajabi-productswindowin Rails version so its now truly optionalRelated
SAGE-240 and SAGE-56