Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next version bump #1580

Merged
merged 38 commits into from
Sep 9, 2022
Merged

Next version bump #1580

merged 38 commits into from
Sep 9, 2022

Conversation

philschanely
Copy link
Contributor

@philschanely philschanely commented Sep 8, 2022 •
edited by QuintonJason
Loading

  1. (LOW) Icon: Remove deprecated icons from v7 and prior #1575 Deprecated icons fully removed from Sage.
  2. (Medium) Pagination: Single-page behavior, style, and window prop updates #1574 Style and configuration improvements to Pagination including:
    • Clearer disabled buttons
    • When only one page, still show component with one page (improves UX and accessibility)
    • Provides default value for window in Rails version so its now truly optional
  3. (LOw) [SAGE-144]: Add NilClass to all optional props (Rails) #1577 Adds NilClass to all optional props. No effect is expected on KP.
  4. (LOW) [SAGE-797]: Form element spacing and color adjustments spec alignment #1579 Updates spacing and colors related to form elements to match design specs. Styling only updates.
  5. (LOW) [SAGE-793] add disclosure button #1572 Add disclosure button for menus and dropdowns. New feature that does not currently in the app
  6. (MEDIUM) [SAGE-795] Transactions table hover behavior #1578 Removed the z-index from SageTable.
    • Transactions page
  7. (LOW) [SAGE-798] Icon - update the select icon to enlarge #1581 Bug fix only related to the documentation site.

philschanely and others added 14 commits September 1, 2022 14:06
@philschanely
feat(pagination): update styles to latest spec
e288b6d 
- Remove :hover styles where no longer needed
- Update color values
- Add round border radius
@philschanely
feat(pagination): update how a single page is handled
c4b8cef
@philschanely
feat(icon): remove deprecated icons
42a5ab2
@philschanely
feat(icon): remove additional deprecated icon
444c0aa
@philschanely
feat(pagination): in Rails, provide a fallback value for window so …
2637c99 
…its truly optional
@philschanely
feat(pagination): documentation regarding default value for window
6fd59df
@philschanely
chore(pagination): tidy Rails logic from feedback
aabf634
@philschanely
Merge pull request #1575 from Kajabi/SAGE-700/pjs-remove-deprecated-v…
23c7c55 
…7-icons

Icon: Remove deprecated icons from v7 and prior
@pixelflips
fix(alert): adjust sage alert nilClass
4bc05df
@pixelflips
fix(rails components): add NilClass to optional props
9a025e3
@pixelflips
fix(alert): fix typo
3db65a2
@philschanely
chore(pagination): adjust prop type from feedback
d24dda5
@philschanely
Merge pull request #1574 from Kajabi/SAGE-240/pjs-pagination-1p-behav…
4e1e539 
…ior-sync

Pagination: Single-page behavior, style, and `window` prop updates
@pixelflips
fix(card list): bring back string removed by mistake from prop - hat-…
3f66e24 
…tip @goodwinchris
pixelflips and others added 15 commits September 8, 2022 11:18
@pixelflips
Merge pull request #1577 from Kajabi/SAGE-144_pl-nil-on-optional-prop…
97f36ca 
…s-rails

[SAGE-144]: Add NilClass to all optional props (Rails)
@kajabi-bot @pixelflips
chore(ci): updating rails gem version [ci skip]
3737185
@kajabi-bot @pixelflips
chore(release): publish [skip ci]
fe2c154 
 - @kajabi/sage@5.3.0
 - @kajabi/sage-assets@1.0.4
 - @kajabi/sage-packs@1.0.4
 - @kajabi/sage-react@1.2.0
 - @kajabi/sage-system@1.0.1
@kajabi-bot @pixelflips
chore(ci): updating rails gem version [ci skip]
1356395
@kajabi-bot @pixelflips
chore(release): publish [skip ci]
f9e3971 
 - @kajabi/sage@5.4.0
 - @kajabi/sage-assets@1.1.0
 - @kajabi/sage-packs@1.0.5
 - @kajabi/sage-react@1.3.0
 - @kajabi/sage-system@1.1.0
@pixelflips
style(form elements): spacing and color adjustments
3387586
@pixelflips
style(form elements): spacing and color adjustments
42b20fd
@pixelflips
style(form elements): spacing and color adjustments
3b49905
@pixelflips
style(form elements): spacing and color adjustments
8f92b10
@pixelflips
Revert "chore(release): publish [skip ci]"
b193b85 
This reverts commit f9e3971.
@pixelflips
Revert "chore(ci): updating rails gem version [ci skip]"
535979e 
This reverts commit 1356395.
@pixelflips
Revert "chore(release): publish [skip ci]"
9a4b1bb 
This reverts commit fe2c154.
@pixelflips
Revert "chore(ci): updating rails gem version [ci skip]"
5b34094 
This reverts commit 3737185.
@pixelflips
Merge pull request #1579 from Kajabi/SAGE-797_pl-form-element-adjustm…
cf8ad09 
…ents

[SAGE-797]: Form element spacing and color adjustments spec alignment
@QuintonJason
fix(button): add disclosure button and apply to dropdown
9ed590e
@ju-Skinner ju-Skinner marked this pull request as ready for review September 9, 2022 12:30
@ju-Skinner ju-Skinner merged commit 653d59b into main Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Version Bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@philschanely @pixelflips @ju-Skinner @kajabi-bot @QuintonJason